Skip to content

Allow to override events and expected version #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexeyzimarev merged 15 commits into from
Dec 27, 2024
Merged

Allow to override events and expected version #397

alexeyzimarev merged 15 commits into from
Dec 27, 2024

Conversation

@alexeyzimarev
Copy link
Contributor

@alexeyzimarev alexeyzimarev commented Dec 23, 2024 •
edited
Loading

Also, can add or remove events. Fixes #398

@github-actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Test Results

 28 files  + 14   28 suites  +14   1h 20m 21s ⏱️ + 51m 0s
193 tests +  3  193 ✅ +  3  0 💤 ±0  0 ❌ ±0 
388 runs  +196  388 ✅ +196  0 💤 ±0  0 ❌ ±0 

Results for commit 4245099. ± Comparison against base commit 4007e08.

This pull request removes 4 and adds 7 tests. Note that renamed tests count towards both. 
Eventuous.Tests.EventStore.Metrics.MetricsTests ‑ ShouldMeasureSubscriptionGapCountBase
Eventuous.Tests.Postgres.Metrics.MetricsTests ‑ ShouldMeasureSubscriptionGapCountBase
Eventuous.Tests.SqlServer.Metrics.MetricsTests ‑ ShouldMeasureSubscriptionGapCountBase
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(CommitPositionSequence, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-12-22T11:34:20.4517102+00:00 })

Eventuous.Tests.Application.CommandServiceTests ‑ Should_execute_amended_append
Eventuous.Tests.Application.FunctionalServiceTests ‑ Should_execute_amended_append
Eventuous.Tests.EventStore.Metrics.MetricsTests ‑ ShouldMeasureSubscriptionGapCountBase_Esdb
Eventuous.Tests.Postgres.Metrics.MetricsTests ‑ ShouldMeasureSubscriptionGapCountBase_Postgres
Eventuous.Tests.SqlServer.Metrics.MetricsTests ‑ ShouldMeasureSubscriptionGapCountBase_SqlServer
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(CommitPositionSequence, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-12-27T11:13:34.7683770+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(CommitPositionSequence, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-12-27T11:13:48.5103024+00:00 })

♻️ This comment has been updated with latest results.

@alexeyzimarev alexeyzimarev merged commit 1d3ccf2 into dev Dec 27, 2024
4 checks passed
@alexeyzimarev alexeyzimarev deleted the amend-append branch December 27, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow skipping concurrency checks

2 participants

@alexeyzimarev